Skip to content

Commit

Permalink
net: phy: icplus: use the .soft_reset() of the phy-core
Browse files Browse the repository at this point in the history
The PHY core already resets the PHY before .config_init() if a
.soft_reset() op is registered. Drop the open-coded ip1xx_reset().

Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michael Walle authored and David S. Miller committed Feb 11, 2021
1 parent 8edf206 commit df22de9
Showing 1 changed file with 2 additions and 30 deletions.
32 changes: 2 additions & 30 deletions drivers/net/phy/icplus.c
Original file line number Diff line number Diff line change
Expand Up @@ -120,36 +120,10 @@ static int ip175c_config_init(struct phy_device *phydev)
return 0;
}

static int ip1xx_reset(struct phy_device *phydev)
{
int bmcr;

/* Software Reset PHY */
bmcr = phy_read(phydev, MII_BMCR);
if (bmcr < 0)
return bmcr;
bmcr |= BMCR_RESET;
bmcr = phy_write(phydev, MII_BMCR, bmcr);
if (bmcr < 0)
return bmcr;

do {
bmcr = phy_read(phydev, MII_BMCR);
if (bmcr < 0)
return bmcr;
} while (bmcr & BMCR_RESET);

return 0;
}

static int ip1001_config_init(struct phy_device *phydev)
{
int c;

c = ip1xx_reset(phydev);
if (c < 0)
return c;

/* Enable Auto Power Saving mode */
c = phy_read(phydev, IP1001_SPEC_CTRL_STATUS_2);
if (c < 0)
Expand Down Expand Up @@ -237,10 +211,6 @@ static int ip101a_g_config_init(struct phy_device *phydev)
struct ip101a_g_phy_priv *priv = phydev->priv;
int err, c;

c = ip1xx_reset(phydev);
if (c < 0)
return c;

/* configure the RXER/INTR_32 pin of the 32-pin IP101GR if needed: */
switch (priv->sel_intr32) {
case IP101GR_SEL_INTR32_RXER:
Expand Down Expand Up @@ -346,6 +316,7 @@ static struct phy_driver icplus_driver[] = {
.name = "ICPlus IP1001",
/* PHY_GBIT_FEATURES */
.config_init = ip1001_config_init,
.soft_reset = genphy_soft_reset,
.suspend = genphy_suspend,
.resume = genphy_resume,
}, {
Expand All @@ -356,6 +327,7 @@ static struct phy_driver icplus_driver[] = {
.config_intr = ip101a_g_config_intr,
.handle_interrupt = ip101a_g_handle_interrupt,
.config_init = ip101a_g_config_init,
.soft_reset = genphy_soft_reset,
.suspend = genphy_suspend,
.resume = genphy_resume,
} };
Expand Down

0 comments on commit df22de9

Please sign in to comment.