Skip to content

Commit

Permalink
ipv6: make addrconf_wq single threaded
Browse files Browse the repository at this point in the history
Both addrconf_verify_work() and addrconf_dad_work() acquire rtnl,
there is no point trying to have one thread per cpu.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20240201173031.3654257-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Eric Dumazet authored and Jakub Kicinski committed Feb 3, 2024
1 parent f5d5923 commit dfd2ee0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/ipv6/addrconf.c
Original file line number Diff line number Diff line change
Expand Up @@ -7349,7 +7349,8 @@ int __init addrconf_init(void)
if (err < 0)
goto out_addrlabel;

addrconf_wq = create_workqueue("ipv6_addrconf");
/* All works using addrconf_wq need to lock rtnl. */
addrconf_wq = create_singlethread_workqueue("ipv6_addrconf");
if (!addrconf_wq) {
err = -ENOMEM;
goto out_nowq;
Expand Down

0 comments on commit dfd2ee0

Please sign in to comment.