Skip to content

Commit

Permalink
ethtool: make validate_speed accept all speeds between 0 and INT_MAX
Browse files Browse the repository at this point in the history
Devices these days can have any speed and as was recently pointed out
any speed from 0 to INT_MAX is valid so adjust speed validation to
accept such values.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nikolay Aleksandrov authored and David S. Miller committed Feb 11, 2016
1 parent 83840f5 commit e02564e
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions include/uapi/linux/ethtool.h
Original file line number Diff line number Diff line change
Expand Up @@ -1377,24 +1377,7 @@ enum ethtool_sfeatures_retval_bits {

static inline int ethtool_validate_speed(__u32 speed)
{
switch (speed) {
case SPEED_10:
case SPEED_100:
case SPEED_1000:
case SPEED_2500:
case SPEED_5000:
case SPEED_10000:
case SPEED_20000:
case SPEED_25000:
case SPEED_40000:
case SPEED_50000:
case SPEED_56000:
case SPEED_100000:
case SPEED_UNKNOWN:
return 1;
}

return 0;
return speed <= INT_MAX || speed == SPEED_UNKNOWN;
}

/* Duplex, half or full. */
Expand Down

0 comments on commit e02564e

Please sign in to comment.