Skip to content

Commit

Permalink
ASoC: q6asm: use flags directly from q6asm-dai
Browse files Browse the repository at this point in the history
use flags set by q6asm-dais directly!

This will be useful gapless case where write needs a special flag to indicate
that last buffer.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tested-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20200727093806.17089-4-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Srinivas Kandagatla authored and Mark Brown committed Aug 17, 2020
1 parent 789e3b6 commit e0c078a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
8 changes: 4 additions & 4 deletions sound/soc/qcom/qdsp6/q6asm-dai.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ static void event_handler(uint32_t opcode, uint32_t token,
case ASM_CLIENT_EVENT_CMD_RUN_DONE:
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
q6asm_write_async(prtd->audio_client, prtd->stream_id,
prtd->pcm_count, 0, 0, NO_TIMESTAMP);
prtd->pcm_count, 0, 0, 0);
break;
case ASM_CLIENT_EVENT_CMD_EOS_DONE:
prtd->state = Q6ASM_STREAM_STOPPED;
Expand All @@ -193,7 +193,7 @@ static void event_handler(uint32_t opcode, uint32_t token,
snd_pcm_period_elapsed(substream);
if (prtd->state == Q6ASM_STREAM_RUNNING)
q6asm_write_async(prtd->audio_client, prtd->stream_id,
prtd->pcm_count, 0, 0, NO_TIMESTAMP);
prtd->pcm_count, 0, 0, 0);

break;
}
Expand Down Expand Up @@ -512,7 +512,7 @@ static void compress_event_handler(uint32_t opcode, uint32_t token,
spin_lock_irqsave(&prtd->lock, flags);
if (!prtd->bytes_sent) {
q6asm_write_async(prtd->audio_client, prtd->stream_id,
prtd->pcm_count, 0, 0, NO_TIMESTAMP);
prtd->pcm_count, 0, 0, 0);
prtd->bytes_sent += prtd->pcm_count;
}

Expand All @@ -538,7 +538,7 @@ static void compress_event_handler(uint32_t opcode, uint32_t token,

if (avail >= prtd->pcm_count) {
q6asm_write_async(prtd->audio_client, prtd->stream_id,
prtd->pcm_count, 0, 0, NO_TIMESTAMP);
prtd->pcm_count, 0, 0, 0);
prtd->bytes_sent += prtd->pcm_count;
}

Expand Down
5 changes: 1 addition & 4 deletions sound/soc/qcom/qdsp6/q6asm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1546,10 +1546,7 @@ int q6asm_write_async(struct audio_client *ac, uint32_t stream_id, uint32_t len,
write->mem_map_handle =
ac->port[SNDRV_PCM_STREAM_PLAYBACK].mem_map_handle;

if (wflags == NO_TIMESTAMP)
write->flags = (wflags & 0x800000FF);
else
write->flags = (0x80000000 | wflags);
write->flags = wflags;

port->dsp_buf++;

Expand Down
1 change: 0 additions & 1 deletion sound/soc/qcom/qdsp6/q6asm.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ enum {
};

#define MAX_SESSIONS 8
#define NO_TIMESTAMP 0xFF00
#define FORMAT_LINEAR_PCM 0x0000

struct q6asm_flac_cfg {
Expand Down

0 comments on commit e0c078a

Please sign in to comment.