Skip to content

Commit

Permalink
Merge branch 'net-smc-userspace-breakage-fixes'
Browse files Browse the repository at this point in the history
Eugene Syromiatnikov says:

====================
net/smc: userspace breakage fixes

These two patches correct some userspace-affecting issues introduced
during 4.19 development cycle, specifically:
 * New structure "struct smcd_diag_dmbinfo" has been defined in a way
   that would lead to different layout of the structure on most 32-bit
   ABIs in comparison with layout on 64-bit ABIs;
 * One of the commits renamed an UAPI-exposed field name.

Changes since v1:
 * Managed not to forget to add --cover-letter.
 * Commit ID format in commit message has been changed in accordance
   with Sergei Shtylyov's recommendations.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Oct 8, 2018
2 parents 6d4c407 + d4f0006 commit e2a322a
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions include/uapi/linux/smc_diag.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,17 @@ struct smc_diag_req {
* on the internal clcsock, and more SMC-related socket data
*/
struct smc_diag_msg {
__u8 diag_family;
__u8 diag_state;
__u8 diag_mode;
__u8 diag_shutdown;
__u8 diag_family;
__u8 diag_state;
union {
__u8 diag_mode;
__u8 diag_fallback; /* the old name of the field */
};
__u8 diag_shutdown;
struct inet_diag_sockid id;

__u32 diag_uid;
__u64 diag_inode;
__u32 diag_uid;
__aligned_u64 diag_inode;
};

/* Mode of a connection */
Expand Down Expand Up @@ -99,11 +102,11 @@ struct smc_diag_fallback {
};

struct smcd_diag_dmbinfo { /* SMC-D Socket internals */
__u32 linkid; /* Link identifier */
__u64 peer_gid; /* Peer GID */
__u64 my_gid; /* My GID */
__u64 token; /* Token of DMB */
__u64 peer_token; /* Token of remote DMBE */
__u32 linkid; /* Link identifier */
__aligned_u64 peer_gid; /* Peer GID */
__aligned_u64 my_gid; /* My GID */
__aligned_u64 token; /* Token of DMB */
__aligned_u64 peer_token; /* Token of remote DMBE */
};

#endif /* _UAPI_SMC_DIAG_H_ */

0 comments on commit e2a322a

Please sign in to comment.