Skip to content

Commit

Permalink
drm/i915: Remove redundant queue_delayed_work() from throttle ioctl
Browse files Browse the repository at this point in the history
We know, by design, that whilst the GPU is active (and thus we are
throttling) the retire_worker is queued. Therefore attempting to requeue
it with queue_delayed_work() is a no-op and we can safely remove it.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1467616119-4093-3-git-send-email-chris@chris-wilson.co.uk
  • Loading branch information
Chris Wilson committed Jul 4, 2016
1 parent 1b51bce commit e307d62
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/gpu/drm/i915/i915_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -4467,9 +4467,6 @@ i915_gem_ring_throttle(struct drm_device *dev, struct drm_file *file)
return 0;

ret = __i915_wait_request(target, true, NULL, NULL);
if (ret == 0)
queue_delayed_work(dev_priv->wq, &dev_priv->gt.retire_work, 0);

i915_gem_request_unreference(target);

return ret;
Expand Down

0 comments on commit e307d62

Please sign in to comment.