Skip to content

Commit

Permalink
platform/x86: asus-wmi: Fix regression when probing for fan curve con…
Browse files Browse the repository at this point in the history
…trol

The fan curve control patches introduced a regression for at least the
TUF FX506 and possibly other TUF series laptops that do not have support
for fan curve control.

As part of the probing process, asus_wmi_evaluate_method_buf is called
to get the factory default fan curve . The WMI management function
returns 0 on certain laptops to indicate lack of fan curve control
instead of ASUS_WMI_UNSUPPORTED_METHOD. This 0 is transformed to
-ENODATA which results in failure when probing.

Fixes: 0f0ac15 ("platform/x86: asus-wmi: Add support for custom fan curves")
Reported-and-tested-by: Abhijeet V <abhijeetviswa@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220205112840.33095-1-hdegoede@redhat.com
  • Loading branch information
Hans de Goede committed Feb 5, 2022
1 parent 868d761 commit e3d13da
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/platform/x86/asus-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -2223,7 +2223,7 @@ static int fan_curve_check_present(struct asus_wmi *asus, bool *available,

err = fan_curve_get_factory_default(asus, fan_dev);
if (err) {
if (err == -ENODEV)
if (err == -ENODEV || err == -ENODATA)
return 0;
return err;
}
Expand Down

0 comments on commit e3d13da

Please sign in to comment.