Skip to content

Commit

Permalink
perf tools: Get rid of dso__data_fd() from dso__data_size()
Browse files Browse the repository at this point in the history
It seems that the dso__data_fd() was needed to find a binary type
since open in data_file_size() alone used to fail.

But as it can open the dso fine now, the dso__data_fd() can go away.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1432137821-10853-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed May 27, 2015
1 parent 71ff824 commit e840238
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tools/perf/util/dso.c
Original file line number Diff line number Diff line change
Expand Up @@ -745,12 +745,6 @@ static int data_file_size(struct dso *dso, struct machine *machine)
*/
off_t dso__data_size(struct dso *dso, struct machine *machine)
{
int fd;

fd = dso__data_fd(dso, machine);
if (fd < 0)
return fd;

if (data_file_size(dso, machine))
return -1;

Expand Down

0 comments on commit e840238

Please sign in to comment.