Skip to content

Commit

Permalink
selftests: forwarding: Tweak tc filters for mirror-to-gretap tests
Browse files Browse the repository at this point in the history
When running mirror_gre_bridge_1d_vlan tests on veth, several issues
cause spurious failures:

- vlan_ethtype should be ip, not ipv6 even in mirror-to-ip6gretap case,
  because the overlay packet is still IPv4.
- Similarly ip_proto matches the innermost IP protocol, so can't be used
  to filter out GRE packet. Drop the corresponding condition.
- Because the above fixes the filters to match in slow path as well,
  they need to be made skip_hw so as not to double-count packets.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Petr Machata authored and David S. Miller committed Jun 30, 2018
1 parent ac0fcad commit ec9fdc9
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,14 @@ test_vlan_match()

test_gretap()
{
test_vlan_match gt4 'vlan_id 555 vlan_ethtype ip' "mirror to gretap"
test_vlan_match gt4 'skip_hw vlan_id 555 vlan_ethtype ip' \
"mirror to gretap"
}

test_ip6gretap()
{
test_vlan_match gt6 'vlan_id 555 vlan_ethtype ipv6' "mirror to ip6gretap"
test_vlan_match gt6 'skip_hw vlan_id 555 vlan_ethtype ip' \
"mirror to ip6gretap"
}

test_gretap_stp()
Expand Down
2 changes: 1 addition & 1 deletion tools/testing/selftests/net/forwarding/mirror_gre_lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ full_test_span_gre_dir_vlan_ips()
"$backward_type" "$ip1" "$ip2"

tc filter add dev $h3 ingress pref 77 prot 802.1q \
flower $vlan_match ip_proto 0x2f \
flower $vlan_match \
action pass
mirror_test v$h1 $ip1 $ip2 $h3 77 10
tc filter del dev $h3 ingress pref 77
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,14 @@ test_vlan_match()

test_gretap()
{
test_vlan_match gt4 'vlan_id 555 vlan_ethtype ip' "mirror to gretap"
test_vlan_match gt4 'skip_hw vlan_id 555 vlan_ethtype ip' \
"mirror to gretap"
}

test_ip6gretap()
{
test_vlan_match gt6 'vlan_id 555 vlan_ethtype ipv6' "mirror to ip6gretap"
test_vlan_match gt6 'skip_hw vlan_id 555 vlan_ethtype ip' \
"mirror to ip6gretap"
}

test_span_gre_forbidden_cpu()
Expand Down

0 comments on commit ec9fdc9

Please sign in to comment.