Skip to content

Commit

Permalink
tg3: Remove unnecessary lock around tg3_flag_set
Browse files Browse the repository at this point in the history
The spinlock was needed when flags used to be a u32 and set/cleared
using bit operations. Now that we use the atomic set_bit, this lock
isn't needed.

Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nithin Sujir authored and David S. Miller committed May 25, 2013
1 parent 7c10ee3 commit f2068b8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/broadcom/tg3.c
Original file line number Diff line number Diff line change
Expand Up @@ -6386,9 +6386,7 @@ static void tg3_tx_recover(struct tg3 *tp)
"Please report the problem to the driver maintainer "
"and include system chipset information.\n");

spin_lock(&tp->lock);
tg3_flag_set(tp, TX_RECOVERY_PENDING);
spin_unlock(&tp->lock);
}

static inline u32 tg3_tx_avail(struct tg3_napi *tnapi)
Expand Down

0 comments on commit f2068b8

Please sign in to comment.