Skip to content

Commit

Permalink
ima: Use kmemdup rather than kmalloc+memcpy
Browse files Browse the repository at this point in the history
Issue identified with Coccinelle.

Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
  • Loading branch information
Alex Dewar authored and Mimi Zohar committed Sep 15, 2020
1 parent 8c2f516 commit f60c826
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions security/integrity/ima/ima_policy.c
Original file line number Diff line number Diff line change
Expand Up @@ -353,15 +353,14 @@ static struct ima_rule_entry *ima_lsm_copy_rule(struct ima_rule_entry *entry)
struct ima_rule_entry *nentry;
int i;

nentry = kmalloc(sizeof(*nentry), GFP_KERNEL);
if (!nentry)
return NULL;

/*
* Immutable elements are copied over as pointers and data; only
* lsm rules can change
*/
memcpy(nentry, entry, sizeof(*nentry));
nentry = kmemdup(entry, sizeof(*nentry), GFP_KERNEL);
if (!nentry)
return NULL;

memset(nentry->lsm, 0, sizeof_field(struct ima_rule_entry, lsm));

for (i = 0; i < MAX_LSM_RULES; i++) {
Expand Down

0 comments on commit f60c826

Please sign in to comment.