Skip to content

Commit

Permalink
cls_bpf: Use kmemdup instead of duplicating it in cls_bpf_prog_from_ops
Browse files Browse the repository at this point in the history
Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
YueHaibing authored and David S. Miller committed Jul 29, 2018
1 parent 0a80848 commit f9562fa
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions net/sched/cls_bpf.c
Original file line number Diff line number Diff line change
Expand Up @@ -349,12 +349,10 @@ static int cls_bpf_prog_from_ops(struct nlattr **tb, struct cls_bpf_prog *prog)
if (bpf_size != nla_len(tb[TCA_BPF_OPS]))
return -EINVAL;

bpf_ops = kzalloc(bpf_size, GFP_KERNEL);
bpf_ops = kmemdup(nla_data(tb[TCA_BPF_OPS]), bpf_size, GFP_KERNEL);
if (bpf_ops == NULL)
return -ENOMEM;

memcpy(bpf_ops, nla_data(tb[TCA_BPF_OPS]), bpf_size);

fprog_tmp.len = bpf_num_ops;
fprog_tmp.filter = bpf_ops;

Expand Down

0 comments on commit f9562fa

Please sign in to comment.