Skip to content

Commit

Permalink
drm/amdgpu: not to save bo in the case of RAS err_event_athub
Browse files Browse the repository at this point in the history
err_event_athub will corrupt VCPU buffer and not good to
be restored in amdgpu_vcn_resume() and in this case
the VCPU buffer needs to be cleared for VCN firmware to
work properly.

Acked-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: David (Ming Qiang) Wu <David.Wu3@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
David (Ming Qiang) Wu authored and Alex Deucher committed Sep 26, 2023
1 parent 9ed630c commit fa1f1cc
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,15 @@ int amdgpu_vcn_suspend(struct amdgpu_device *adev)
void *ptr;
int i, idx;

bool in_ras_intr = amdgpu_ras_intr_triggered();

cancel_delayed_work_sync(&adev->vcn.idle_work);

/* err_event_athub will corrupt VCPU buffer, so we need to
* restore fw data and clear buffer in amdgpu_vcn_resume() */
if (in_ras_intr)
return 0;

for (i = 0; i < adev->vcn.num_vcn_inst; ++i) {
if (adev->vcn.harvest_config & (1 << i))
continue;
Expand Down

0 comments on commit fa1f1cc

Please sign in to comment.