From fa9e3139e6c5ac756e1ab2a6c7eca99eb684a2fe Mon Sep 17 00:00:00 2001 From: Sumanth Korikkar Date: Thu, 7 Mar 2024 09:46:11 +0100 Subject: [PATCH] s390/tools: handle rela R_390_GOTPCDBL/R_390_GOTOFF64 lkp test robot reported unhandled relocation type: R_390_GOTPCDBL, when kernel is built with -fno-PIE. relocs tool reads vmlinux and handles absolute relocations. PC relative relocs doesn't need adjustment. Also, the R_390_GOTPCDBL/R_390_GOTOFF64 relocations are present currently only when KASAN is enabled. The following program can create a R_390_GOTPCDBL/R_390_GOTOFF64 reloc (with fPIE/fPIC). void funcb(int *b) { *b = *b + 100; } void gen_gotoff(void) { int b = 10; funcb (&b); } gcc -c sample.c -fPIC -fsanitize=kernel-address --param asan-stack=1 The above example (built with -fPIC) was linked to one of the built-in.a (built with -fno-PIE) and checked for correctness with kaslr enabled. Both the relocs turns out relative and can be skipped. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202402221404.T2TGs8El-lkp@intel.com/ Fixes: 55dc65b46023 ("s390: add relocs tool") Signed-off-by: Sumanth Korikkar Acked-by: Vasily Gorbik Signed-off-by: Heiko Carstens --- arch/s390/tools/relocs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/s390/tools/relocs.c b/arch/s390/tools/relocs.c index db8bcbf9d8f8f..30a732c808f35 100644 --- a/arch/s390/tools/relocs.c +++ b/arch/s390/tools/relocs.c @@ -276,6 +276,8 @@ static int do_reloc(struct section *sec, Elf_Rel *rel) case R_390_PC32DBL: case R_390_PLT32DBL: case R_390_GOTENT: + case R_390_GOTPCDBL: + case R_390_GOTOFF64: break; case R_390_64: add_reloc(&relocs64, offset);