From ff62433883b3ab753a78954ecf46e2c514f5c407 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 7 Feb 2022 11:24:39 +0300 Subject: [PATCH] net: dsa: mv88e6xxx: Unlock on error in mv88e6xxx_port_bridge_join() Call mv88e6xxx_reg_unlock(chip) before returning on this error path. Fixes: 7af4a361a62f ("net: dsa: mv88e6xxx: Improve isolation of standalone ports") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 192a7688b4df1..c54649c4c3a01 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2602,7 +2602,7 @@ static int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port, err = mv88e6xxx_port_set_map_da(chip, port, true); if (err) - return err; + goto unlock; err = mv88e6xxx_port_commit_pvid(chip, port); if (err)