From 84a66e45ec70a30eb73194c8bd6fde48403d5d79 Mon Sep 17 00:00:00 2001 From: Donald Buczek Date: Thu, 5 May 2022 18:35:58 +0200 Subject: [PATCH] mxqd: Do not disconnect from mysql before helper call The helpers are trusted code, they won't do something nasty with the connected mysql socket. So don't disconnect from and reconnect to the mysql server when we call the tmpdir-setup helper. --- mxqd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mxqd.c b/mxqd.c index 6bb06af0..01d5d161 100644 --- a/mxqd.c +++ b/mxqd.c @@ -1308,7 +1308,6 @@ static unsigned long start_job(struct mxq_group_list *glist) } if (group->job_tmpdir_size > 0) { - mx_mysql_disconnect(server->mysql); char *argv[] = { tmpdir_script, "create", @@ -1321,7 +1320,6 @@ static unsigned long start_job(struct mxq_group_list *glist) free(argv[2]); free(argv[3]); free(argv[4]); - mx_mysql_connect_forever(&(server->mysql)); if (status == -1) { mx_log_err("create job tmpdir: %m"); mxq_unload_job_from_server(server->mysql, job->job_id);