From b1a1282e66a63195c853ddafbd38517a923b9f1e Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Wed, 1 Sep 2021 13:03:44 +0200 Subject: [PATCH] mxqdump: List switch `-a`/`--all` for jobs-options in usage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With `mxqdump`, currently, reading the usage, it’s not clear how to dump all jobs in a group without any filtering on the status, which defaults to *running*. The code actually check if `arg_all` is set, meaning the switch `-a`/`--all` is passed. So, document that in the usage. Instead of `-a`/`--all` also `--status=all` or `--status=any` would be possible, but also takes a different code path. As that is invisible to the user, mention it as an alias. Passing `--debug` shows the code paths taken: $ mxqdump --debug --jobs -g 472581 -a mxqdump mxqdump.c:737:main(): MySQL: Connection to database established. mxqdump mxqdump.c:747:main(): DEBUG: DO: print all jobs in group_id=472581 […] $ mxqdump --debug --jobs -g 472581 --status=all # or any mxqdump mxqdump.c:737:main(): MySQL: Connection to database established. mxqdump mxqdump.c:754:main(): DEBUG: DO: print jobs in group_id=472581 with status='invalid(18446744073709551614)' […] Fixes: https://github.molgen.mpg.de/mariux64/mxq/issues/74 --- mxqdump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mxqdump.c b/mxqdump.c index d3f2f23e..6ae59838 100644 --- a/mxqdump.c +++ b/mxqdump.c @@ -60,10 +60,12 @@ static void print_usage(void) "\n\n" "[jobs-options]:\n" " -u, --user [username|uid] filter user/everybodys jobs (default: own uid)\n" + " -a, --all no user filter - dump all jobs with status running\n" " -g, --group-id filter jobs in group with \n" " -s, --status filter jobs with (default: running)\n" " (only available when --group-id is set)\n" "\n" + " -a, --all alias for '--status=all'\n" " -q, --inq alias for '--status=inq'\n" " -r, --running alias for '--status=running'\n" " -f, --finished alias for '--status=finished'\n"