From 0b2b426db83323cead1df7a63ff9efd57e38d649 Mon Sep 17 00:00:00 2001 From: Donald Buczek Date: Mon, 12 Mar 2018 12:08:31 +0100 Subject: [PATCH] mxrouter: Create interfaces before applying settings Interface-specific settings (ipv4_send_redirects, ipv4_rp_filter, ipv6_accept_ra) were applied to early, when new vlan interfaces not yet existed. Change order of code blocks. --- mxrouter/mxrouterctl | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/mxrouter/mxrouterctl b/mxrouter/mxrouterctl index f912d24..3c43140 100755 --- a/mxrouter/mxrouterctl +++ b/mxrouter/mxrouterctl @@ -481,6 +481,17 @@ sub start { set_ipv4_routing(1); } + stop_process_if($process_ulogd); + stop_process_if($process_dhcrelay); + stop_process_if($process_radvd); + unconfigure_route($del_route); + unconfigure_ip($del_addr); + unconfigure_vlans($del_vlan,{}); + + configure_vlans($new_vlan,{}); + configure_ip($new_addr); + configure_route($new_route); + for my $dev ('all','default',network_devices()) { if (get_ipv4_send_redirects($dev)>0) { warn "disable IPV4 send redirects on $dev\n" unless $opt_quiet; @@ -502,16 +513,6 @@ sub start { } } - stop_process_if($process_ulogd); - stop_process_if($process_dhcrelay); - stop_process_if($process_radvd); - unconfigure_route($del_route); - unconfigure_ip($del_addr); - unconfigure_vlans($del_vlan,{}); - - configure_vlans($new_vlan,{}); - configure_ip($new_addr); - configure_route($new_route); start_process_if($process_ulogd); start_process_if($process_dhcrelay); start_process_if($process_radvd);