From 169d60d93eda8fbf51ef53cff3eeb1f93df82ff4 Mon Sep 17 00:00:00 2001 From: thomas Date: Mon, 30 Apr 2018 08:24:37 +0200 Subject: [PATCH] mxraid_assemble: Code cleanup Proper calls for 'configured_raids'. --- mxraid/mxraid_assemble | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/mxraid/mxraid_assemble b/mxraid/mxraid_assemble index bf23ab1..0fd3622 100755 --- a/mxraid/mxraid_assemble +++ b/mxraid/mxraid_assemble @@ -102,7 +102,7 @@ if ($opts{c}) { print "# NOTE: no active raids found.\n" unless @labels; for my $label (@labels) { print "$label:\n"; - for my $rec (@{$hd->{configured_raids}{$label}}) { # todo write a proper accessor :xxx: + for my $rec (@{$hd->configured_raids()->{$label}}) { printf " %5s %-16s '%s'\n", @$rec; } print "\n"; @@ -448,7 +448,7 @@ exit; } } } - $self->{configured_raids} = \%configured_raids; + $self->configured_raids(\%configured_raids); $self->non_raid_disks(\@non_raid); $self->raid_labels( [ sort keys %raid_labels ] ); } @@ -512,6 +512,12 @@ exit; return $self->{non_raid_disks}; } + sub configured_raids() { + my $self = shift; + $self->{configured_raids} = shift if @_; + $self->{configured_raids}; + } + sub member_serials { my $self = shift; my $label = shift;