Skip to content

Compiled programs causing distribution inconsistencies #135

Closed
pmenzel opened this issue Nov 10, 2020 · 2 comments · Fixed by #137
Closed

Compiled programs causing distribution inconsistencies #135

pmenzel opened this issue Nov 10, 2020 · 2 comments · Fixed by #137

Comments

@pmenzel
Copy link
Contributor

pmenzel commented Nov 10, 2020

Should the binaries also be tracked by git to not run into inconsistencies.

I built setuid/setuid back in 2018, and that was installed on the distmaster.

mxtools (master)$ md5sum setuid/setuid
b7a1ecadb31c3520879c80eb2d1c377f  setuid/setuid
mxtools (master)$ ls -l setuid/setuid
-rwxrwx--- 1 pmenzel pmenzel 16112 Nov  2  2018 setuid/setuid

It looks like, somebody checked out or built setuid a new, and installed that besides the source didn’t change.

@deinemuddah:~$ ls -lh --full-time /usr/sbin/setuid
-rwxr-xr-x 1 root root 24K 2020-11-05 11:46:24.000000000 +0100 /usr/sbin/setuid
@deinemuddah:~$ md5sum /usr/sbin/setuid
291a20cf3e37a29dd0bc93dd98fc2817  /usr/sbin/setuid

So, everytime sudo ./install.sh is run the other version will be installed.

@wwwutz
Copy link
Contributor

wwwutz commented Nov 11, 2020

I find it more disturbing that they're not covered by bee.

@donald
Copy link
Collaborator

donald commented Nov 12, 2020

I wouldn't like to mix binaries into the source archive.

It wouldn't be difficult to create a bee file for that. Its just so much more work when you want to make a trivial change. Now: commit on master, push, make install on distmaster. With bee: commit on master, push, go to github, create a release , go to bee repository, create a branch, change version in bee file, build, push, go to github, merge, go to distmaster, install. Just to increate the memory of pbackup on

Maybe this could be a bit automated... But still.... Wouldn't that bee a lot of work for not much advantage? What problem would we solve here?

If it were only to keep the compilation output of "setuid", I'd rather move setuid out of mxtools into an own package which can be installed with bee. Everything else in mxtools is just installed directly from source (scripts and config files) and is and not build.

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants