Skip to content

openjdk version string #469

Open
donald opened this issue May 29, 2025 · 0 comments
Open

openjdk version string #469

donald opened this issue May 29, 2025 · 0 comments

Comments

@donald
Copy link
Collaborator

donald commented May 29, 2025

Our current openjdk builds don't override --with-version-pre during configure, which defaults to internal:

buczek@claptrap:~/git/pkg-scripts (master)$ java -version
openjdk version "21-internal" 2023-09-19
OpenJDK Runtime Environment (build 21-internal+35)
OpenJDK 64-Bit Server VM (build 21-internal+35, mixed mode, sharing)

At least one product, possibly more, have problems with this:

buczek@claptrap:~/Downloads/px-submission-tool-2.10.1$ java -jar px-submission-tool-2.10.1.jar 
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/buczek/Downloads/px-submission-tool-2.10.1/lib/logback-classic-1.1.6.jar!/org/slf4j/impl/StaticLoggerBinder.class]
[...]
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:661)
	at java.base/java.lang.Integer.parseInt(Integer.java:777)
	at uk.ac.ebi.pride.AppBootstrap.checkJavaVersion(AppBootstrap.java:50)
	at uk.ac.ebi.pride.AppBootstrap.main(AppBootstrap.java:25)
buczek@claptrap:~/Downloads/px-submission-tool-2.10.1$ 

Adding --with-version-pre='' fixes the problem.

buczek@claptrap:~/Downloads/px-submission-tool-2.10.1$ /scratch/tmp/openjdk-21.0.0.35-0/bin/java -version
openjdk version "21" 2023-09-19
OpenJDK Runtime Environment (build 21+35)
OpenJDK 64-Bit Server VM (build 21+35, mixed mode, sharing)
buczek@claptrap:~/Downloads/px-submission-tool-2.10.1$ /scratch/tmp/openjdk-21.0.0.35-0/bin/java -jar px-submission-tool-2.10.1.jar 
[all fine]

Change that on the next build?

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant