mxproxmox: add check pbackup #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add a command which doesn't need to run with privileges to read the credential file. Initialization of the ua needs to read the credential file. Factor out the code to initialize the ua so that we can make that optional on a per-command basis.
donald
force-pushed
the
mxproxmox-add-check-pbackup
branch
2 times, most recently
from
ca75d1a
to
24ee883
Compare
Add new command `check-pbackup`, which makes suggestions, what jobs to add to /etc/mxproxmox/backup-list.dat based on pbackup configuration. The output consists of out-commented lines which can be added to /etc/mxproxmox/backup-list.dat and uncommented one by one to phase in new proxmox backup jobs.
donald
force-pushed
the
mxproxmox-add-check-pbackup
branch
from
24ee883
to
1b5f675
Compare
Remove trailing whitespace from lines read from backup-list.
If we keep trailing whitespace, the following split will keep the
whitespace in $opt_limit. This is later checked with `if
defined($limit)` , which is true. Still, the empty string will evaluate
numerically to zero (with a warning). A limit zero is not what we want
here.
From `perldoc -f split`:
When assigning to a list, if LIMIT is omitted, or zero, Perl supplies a
LIMIT one larger than the number of variables in the list, to avoid
unnecessary work
This has this surprising effect:
DB<1> x split " ","a "
0 'a'
DB<2> @a = split " ","a "
DB<3> x @s
empty array
DB<4> x @a
0 'a'
DB<5> ($a, $b) = split " ","a "
DB<6> x ($a, $b)
0 'a'
1 ''
DB<7>
donald
force-pushed
the
mxproxmox-add-check-pbackup
branch
from
86e9865
to
bbd5231
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command to assist in adding scientific projects to the backup job list of mxproxmox (
/etc/mxproxmox/backup-list.dat).