Skip to content

zig: fix wrong cmake-flags #270

Merged
merged 1 commit into from Feb 6, 2024
Merged

zig: fix wrong cmake-flags #270

merged 1 commit into from Feb 6, 2024

Conversation

niclas
Copy link
Contributor

@niclas niclas commented Jan 19, 2024

This fixes #269.

@niclas
Copy link
Contributor Author

niclas commented Jan 19, 2024

Tested as different user on godsavethequeen:

> cat hello.zig 
const std = @import("std");

pub fn main() void {
        std.debug.print("hello, world!\n", .{});
}
> source /dev/shm/zig-0.11.0-0/profile 
> zig version
0.11.0
> zig run hello.zig 
hello, world!

This fixes #269.

Values for `CMAKE_INSTALL_RPATH`, `CMAKE_PREFIX_PATH` and
`LLD_INCLUDE_DIRS` were wrong or unnecessary. Alse use
Release mode instead of Debug.
@donald
Copy link
Contributor

donald commented Jan 31, 2024

With the TESTING prefix changed from /dev/shm/... to /scratch/local2/..., if fails on theinternet while it seems to work on other systems. Log and exit status okay, but lib is just not installed. Note: For a full rebuild test, /scratch/local/USER/.cache/zig/ should be removed. It shouldn't make a difference, but, of course, there could be a bug and wrong cached output reused.

system user Kernel CPU (fam /model) cmnt libinstalled
theinternet buczek ? E5-1650 v3 (intel 6/63) FAIL
theinternet loser 6.6.11-460 E5-1650 v3 (intel 6/63) FAIL
privateidaho loser 6.1.53-458 EPYC 7343 16-Core (amd 25 /1) OK
claptrap loser 6.6.12-461 E5-2603 v4 (intel 6/79) OK
theinternet loser 6.6.12-461 E5-1650 v3 (intel 6/63) FAIL
theinternet loser 6.6.12-461 E5-1650 v3 (intel 6/63) zig 0.12.0 (master) + llvm 17.0.6 FAIL
baconseed loser 5.15.77-440 E5-1650 v3 (intel 6/63) OK
theinternet loser 6.6.12-461 E5-1650 v3 (intel 6/63) gcc 13.2 FAIL
theinternet loser 6.6.12-461 E5-1650 v3 (intel 6/63) /scratch/local FAIL
theinternet loser 5.15.77-440 E5-1650 v3 (intel 6/63) FAIL
baconseed loser 5.15.77-440 E5-1650 v3 (intel 6/63) /scratch/local FAIL!

@donald
Copy link
Contributor

donald commented Feb 3, 2024

system mountpoint filesystem OK/FAIL
theinternet /scratch/local XFS V4 FAIL
theinternet /scratch/local2 XFS V4 FAIL
inbetweenmove /scratch/local2 XFS V5 OK
baconseed /scratch/local2 XFS V5 OK
baconseed /scratch/local XFS V4 FAIL
claptrap /scratch/local2 XFS V5 OK
gnosiophobie /scratch/local2 XFS V4 FAIL

@donald
Copy link
Contributor

donald commented Feb 4, 2024

mkfs.xfs test
-m crc=0 -s size=4096 -i projid32bit=0 -n ftype=0 FAIL
-m crc=0 -s size=4096 -n ftype=0 FAIL
-m crc=0 -s size=4096 -n ftype=1 OK
-m crc=0 -s size=512 -n ftype=1 OK
-m crc=0 -s size=4096 OK
-m crc=0 $dev_xfs4 OK
default OK

@donald donald merged commit 48053a3 into master Feb 6, 2024
Sign in to join this conversation on GitHub.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zig: unable to find zig installation directory
2 participants