You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Give myself a 'Bummer'-Award, the scripts below contain the following 'gem':
test -n 'XWIPE' && rm -rf ./$dir, what clearly misses the intended use of setting XWIPE to clean source directories when repeating builds, replace with test -n "$XWIPE"
Hehe, I was musing about this and assumed you wanted to edit the line to activate rm -rf. Of course I overlooked that it would require and edit to deactivate it. Aynway, no need to rebuild things because pf this. The build script is functioning. Whoever does the next revision can remove it.
Btw: What is COOKIE=$(mcookie); grep -v V_GREP_ME $0 > /dev/shm/runme-$COOKIE.sh ; sleep 1; exec bash /dev/shm/runme-$COOKIE.sh ?
What about fixing them in a single commit? I think this will reduce the risk of CnP duplication.
As for the COOKIE thing, there is also a note in the wiki. And my intention is to work on the script that just builds. Why the sleep, because I always confuse -v with -w :)
Well, "fixing" in one commit (without changing the build number and rebuilding?) would replace the scripts, which were actually used to build the packages. I'd prefer if the scripts here would be as "untouchable" after the build as the packages.
Give myself a 'Bummer'-Award, the scripts below contain the following 'gem':
test -n 'XWIPE' && rm -rf ./$dir
, what clearly misses the intended use of setting XWIPE to clean source directories when repeating builds, replace withtest -n "$XWIPE"
Fixes are needed in:
CellProfiler-2.2.0-0.build.sh
CellProfiler-3.1.5-0.build.sh
gcc-5.5.0-1.build.sh
git-cola-3.2-0.build.sh
openjdk-7u181-0.build.sh
openjdk-8u171-0.build.sh
python-3.7.1-0.build.sh
The text was updated successfully, but these errors were encountered: