Skip to content

Silly error in some build scripts -- test is always true #37

Closed
thomas opened this issue Nov 15, 2018 · 3 comments
Closed

Silly error in some build scripts -- test is always true #37

thomas opened this issue Nov 15, 2018 · 3 comments

Comments

@thomas
Copy link
Contributor

thomas commented Nov 15, 2018

Give myself a 'Bummer'-Award, the scripts below contain the following 'gem':

test -n 'XWIPE' && rm -rf ./$dir, what clearly misses the intended use of setting XWIPE to clean source directories when repeating builds, replace with test -n "$XWIPE"

Fixes are needed in:

CellProfiler-2.2.0-0.build.sh
CellProfiler-3.1.5-0.build.sh
gcc-5.5.0-1.build.sh
git-cola-3.2-0.build.sh
openjdk-7u181-0.build.sh
openjdk-8u171-0.build.sh
python-3.7.1-0.build.sh

@donald
Copy link
Contributor

donald commented Nov 15, 2018

Hehe, I was musing about this and assumed you wanted to edit the line to activate rm -rf. Of course I overlooked that it would require and edit to deactivate it. Aynway, no need to rebuild things because pf this. The build script is functioning. Whoever does the next revision can remove it.

Btw: What is COOKIE=$(mcookie); grep -v V_GREP_ME $0 > /dev/shm/runme-$COOKIE.sh ; sleep 1; exec bash /dev/shm/runme-$COOKIE.sh ?

@thomas
Copy link
Contributor Author

thomas commented Nov 16, 2018

What about fixing them in a single commit? I think this will reduce the risk of CnP duplication.
As for the COOKIE thing, there is also a note in the wiki. And my intention is to work on the script that just builds. Why the sleep, because I always confuse -v with -w :)

@donald
Copy link
Contributor

donald commented Nov 16, 2018

Well, "fixing" in one commit (without changing the build number and rebuilding?) would replace the scripts, which were actually used to build the packages. I'd prefer if the scripts here would be as "untouchable" after the build as the packages.

@donald donald closed this as completed Apr 18, 2019
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants