From c37414170f9563388c467874f7cec8333973f73e Mon Sep 17 00:00:00 2001 From: Fabian Mauchle Date: Sat, 29 May 2021 18:45:21 +0200 Subject: [PATCH] add some hints for coverity --- dtls.c | 1 + list.h | 2 +- tls.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/dtls.c b/dtls.c index 09aa9ee..c215dc5 100644 --- a/dtls.c +++ b/dtls.c @@ -142,6 +142,7 @@ int dtlsread(SSL *ssl, unsigned char *buf, int num, int timeout, pthread_mutex_t continue; case SSL_ERROR_ZERO_RETURN: debug(DBG_DBG, "dtlsread: got ssl shutdown"); + /* fallthrough */ default: while ((error = ERR_get_error())) debug(DBG_ERR, "dtlsread: SSL: %s", ERR_error_string(error, NULL)); diff --git a/list.h b/list.h index f015b9d..c8c4531 100644 --- a/list.h +++ b/list.h @@ -35,7 +35,7 @@ int list_push(struct list *list, void *data); /* removes first entry from list and returns data */ void *list_shift(struct list *list); -/* removes first entry with matching data pointer */ +/* removes all entries with matching data pointer */ void list_removedata(struct list *list, void *data); /* returns first node */ diff --git a/tls.c b/tls.c index 87bbe2c..8786749 100644 --- a/tls.c +++ b/tls.c @@ -251,6 +251,7 @@ int sslreadtimeout(SSL *ssl, unsigned char *buf, int num, int timeout, pthread_m continue; case SSL_ERROR_ZERO_RETURN: debug(DBG_DBG, "sslreadtimeout: got ssl shutdown"); + /* fallthrough */ default: while ((error = ERR_get_error())) debug(DBG_ERR, "sslreadtimeout: SSL: %s", ERR_error_string(error, NULL));