From d44cc5dd91e86fd5d865ece585f2e151d44d6689 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Tue, 18 Jul 2017 17:46:12 +0200 Subject: [PATCH] xdu: Make format string a string lateral Clang 4.0.0 shows the warnings below. ``` $ CC=clang make clang -Wall -Werror -Wextra -pedantic -std=gnu99 -c -o xdu.o xdu.c xdu.c:218:29: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] fprintf(stderr, usage); ^~~~~ xdu.c:218:29: note: treat the string as an argument to avoid this fprintf(stderr, usage); ^ "%s", xdu.c:226:25: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] fprintf(stderr, usage); ^~~~~ xdu.c:226:25: note: treat the string as an argument to avoid this fprintf(stderr, usage); ^ "%s", ``` --- xdu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xdu.c b/xdu.c index 3c21373..dd0d37c 100644 --- a/xdu.c +++ b/xdu.c @@ -215,7 +215,7 @@ char **argv; xsetup(&argc, argv); if (argc == 1) { if (isatty(fileno(stdin))) { - fprintf(stderr, usage); + fprintf(stderr, "%s", usage); exit(1); } else { parse_file("-"); @@ -223,7 +223,7 @@ char **argv; } else if (argc == 2 && strcmp(argv[1], "-help") != 0) { parse_file(argv[1]); } else { - fprintf(stderr, usage); + fprintf(stderr, "%s", usage); exit(1); } top.size = fix_tree(&top);