From efa72d70220b751a63d1f84f38e4c7c6371e2979 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Tue, 18 Jul 2017 17:52:12 +0200 Subject: [PATCH] xdu: Initialize variables `name` in all cases Clang 4.0.0 warns about the use of a possibly uninitialized variable. ``` $ CC=clang make clang -Wall -Werror -Wextra -pedantic -std=gnu99 -c -o xdu.o xdu.c xdu.c:887:5: error: variable 'name' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] default: ^~~~~~~ xdu.c:892:78: note: uninitialized use occurs here fprintpstext(fp, rect.left + 4, rect.top + (rect.height - rect.top) / 2, name); ^~~~ xdu.c:868:28: note: initialize the variable 'name' to silence this warning char label[1024], *name; ^ = NULL 1 error generated. ``` Only the function `a_saveps()` is the caller of that path, and passes `res.showsize()`. Maybe that parameter should be checked by the caller and an assert be added. Setting the variable to NULl fixes the issue. --- xdu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xdu.c b/xdu.c index dd0d37c..747ce68 100644 --- a/xdu.c +++ b/xdu.c @@ -885,6 +885,7 @@ void savepsnode(FILE * fp, struct node *nodep, struct rect rect, int showsize) name = label; break; default: + name = NULL; break; }