-
Notifications
You must be signed in to change notification settings - Fork 0
Youtube embed does not work properly #109
Comments
I think, we just need to update our wagtail. The YouTube ombed URL in wagtail 2.10 is http://www.youtube.com/oembed . YouTube seems to have switches to https:
wagtail has been updated 1 |
Yes, it works after a Wagtail update. However, just going to a intranet page with an embedded video (without starting it) produces 17 requests to external servers, including doubleclick.net and sends ad cookies around. Also fonts.gstatic.com is back, which I got rid of before as request in #58. I assume, if you are logged in to Google with your browser, the Intranet page access will be related to your Google account. Do we want that? I'll do the Wagtail update anyway (to get to current versions of everything before working on other issues) and this will resolve this problem. But still we should decide, whether we want to use (or possibly disable) the feature. Especially now that we are able to show videos locally. @pmenzel: Do you want make an argument here? |
Works on testserver. Page with embedded youtube video: https://intranet2.molgen.mpg.de/de/service/scientific-service/it/test/ Looks everything else okay on https://intranet2.molgen.mpg.de/ ? |
Maybe it would be a good idea to use the "youtube-nocookie" URL to prevent that the iframe talks to Google services even before the video is started? This would provide a minimum of privacy. I couldn't find a suitable code snippet that would generate something like a consent form, like it is used on the videos page of Duckduckgo. The embed looks pretty small here – only a few hundred pixels in size. Would 100% of the width make more sense? (Or maybe 75%, centered?) But I agree that we should generally avoid using these embeds anyway, I'm not sure about disabling them altogether. |
I've added a solution for the size problem to #111 , preview on testserver, but you might need to shift-reload the page, your browser might have cached the old style sheet. Its a bit ulgy (iframe is allway ugly), but I don't think, there is another way. Take it or leave it :-) |
I tried https://github.com/a-v-l/dsgvo-video-embed and this works, but the page looks so ugly, maybe a plain link would be better. Anyway, I think the mentioned bug is fixed. The question, whether we want that or whether we even want to disable that, is unrelated. Should I merge the update into the live server? |
I'd say, go for it. The full-width video looks good & we can take care of the DSGVO stuff another time … Thank you :) |
Okay.
Demo: https://intranet.molgen.mpg.de/de/service/scientific-service/it/test/ I close this issue, I think its fixed. |
I tried to embed https://www.youtube.com/watch?v=GXQs6CAlZK0
Using the "embed" function of the editor, I get the error message "Für diese URL wurde kein Element gefunden." – is the function broken?
Using Youtube's embed code, the video is appearing only as a narrow strip in the rendered page. This seems wrong, too.
There are ways to generate responsive embeds, but they all need the "after" selector in CSS which is not available with inline styles.
As a workaround, I will download the video with youtube-dl and upload it to our own servers.
The text was updated successfully, but these errors were encountered: