Skip to content

Alternative room numbering system #87

Closed
ballaschk opened this issue Aug 6, 2020 · 5 comments
Closed

Alternative room numbering system #87

ballaschk opened this issue Aug 6, 2020 · 5 comments

Comments

@ballaschk
Copy link
Collaborator

ballaschk commented Aug 6, 2020

"In der Spalte "Raum" gibt es anscheinend eine Zeichenbegrenzung, so dass ich nicht alles aufnehmen konnte, was ich wollte. Die sollte nach Möglichkeit weg. Bei der "Übersetzung" der Raumnummer in die Raumpläne wird bei zwei Raumnummern nur die erste erkannt, die 2. (habe ich durch / getrennt) wird vom System als Einheit mit der ersten Raumnummer behandelt. Es wäre toll, wenn die Nummern auch getrennt erkannt werden könnten."

I can imagine things getting pretty complicated, when comments or additional information is added to the room number field, since string matching would have to know how to discern multiple valid strings from non-matchable ones.

What about having a static table of room numbers (linked to the maps of the building) that the user can select from? Arbitrary strings like "Lager" or "Labor" (existing examples that are also not being translated!) would not be allowed. But a selection of multiple rooms would be possible. At the same time, the system would be less flexible.

@ballaschk
Copy link
Collaborator Author

The same with telephone numbers:

"wenn ich in der Telefonliste im Intranet Zusätze zu den Telefonnummern eintrage, werden diese nicht mehr in den Employee-Editor exportiert und erscheinen somit auch nicht auf der Webseite. Ich habe damit aktuell die Wahl, ob ich Erklärungen zum besseren Verständnis der Telefonnummern in die Liste aufnehme (z.B. Büro, Labor), so die Intranet-Liste komfortabler mache und auf die Darstellung einer Telefonnummer im Internet verzichte (was ich nicht möchte), oder ob ich "nur" die verschiedenen Telefonnummern aufliste und die Leute diese durchtelefonieren lasse."

@donald
Copy link
Member

donald commented Aug 13, 2020

#88 partially addresses the original request (more width for rooms and multiple links if text contains multiple room numbers). This is already activated on the live server.

Converting from free text to structured data has advantages and disadvantages. Anyway, the creation of a complex web interface to enter the structured data would take more time than is currently available. So the cheap solution was picked for now.

I'm not sure yet, whether we can transfer arbitrary free text data to the telephone number field in the employee editor. Needs to be checked later.

@donald
Copy link
Member

donald commented Aug 14, 2020

btw: #88 (already active on life server) also includes a major python & Wagtail update. Watch out of undiscovered problems.

@donald
Copy link
Member

donald commented Aug 18, 2020

phone numbers would work, too, but with a limited character set and we'd need to fix a syntax, because we need to expand the phone numbers from internal to external with (030) 8413 prefix.

@donald
Copy link
Member

donald commented Aug 19, 2020

Multiple rooms ( "E13 (office purchasing dept.) / K.2.73 (warehouse)") and multiple phone numbers ("1132 (office purchasing dept.) / 1317 (warehouse)") are now correctly exported to the employee-editor. The comment in the phone numbers should be limited to ASCII (no Umlaute!).

The software, which is converting from the cms database to ldap trees and which needed to be changed, is not part of this repository.

I close this issue now. If a GUI interface to collect annotated list of room numbers and/or phone numbers as "structured data" is still requested, please open a new issue. I probably won't work in it, but it could be reviewed if we engage an external contractor again.

@donald donald closed this as completed Aug 19, 2020
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants