Fixes #1
Open
Fixes #1
+189
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read each source table once and look up row IDs in memory instead of running one SELECT per linked member. Warn about and skip IDs that are not found instead of aborting.
The error handler printed 'response', which is unset or stale when update_link raises.
Remove the hard-coded API token. Outside of a base, the environment variables dtable_web_url and api_token must be set.
Accept commas with or without spaces and ignore empty elements.
Compare the row IDs currently linked in each row with the ones given by the exported text field and update the link only if they differ. Creating links is expensive, and unlike the "Last Change" time filter this needs no time stamp column and no time window. It catches every mismatch, including links emptied by a common data set sync or edited by hand, and a repeated run does no updates at all. An empty text field now clears the links instead of leaving them untouched. This change in behavior is intentional.
Comparing links with the text fields makes the "Last Change" filter unnecessary. Drop it together with the task_status flag it controlled.
Read cells with get(), so cells left out of a row count as empty. As empty cells now clear links, stop with an error if a column name is not found in the table instead of clearing all links of a column.
list_rows() returns at most 1000 rows, so read the table in pages like the staff and room tables.
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.