Skip to content

discussion: include django apps into this repository? #2

Open
sgfroerer opened this issue Jan 18, 2020 · 1 comment
Open

discussion: include django apps into this repository? #2

sgfroerer opened this issue Jan 18, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@sgfroerer
Copy link
Collaborator

This is just a suggestion.
My impression is that having the django apps ( django-eoaauthors, django-eoaforthcoming, ...) as separate repositories complicates things, while the advantages are questionable.
With the apps in separate repos:

Pros:

  • clear separation between apps, main app

Cons:

  • apps are difficult to test (since they are not standalone, which is why the need to be copied into the eoa-1.5 codebase to be run/tested)
  • apps are not standalone, but depend on resources from the eoa-1.5 repository (e.g. the "base.html" template)
  • apps will most likely never be used in other contexts than eoa-1.5 (also because they aren't really standalone)

"git submodules" might simplify the dependency management and reduce the effort necessary for testing.
Still I think there aren't good reasons for all the hassle. A good reason to separate code would be to prevent unnecessary coupling. Still there is a mutual dependency between the apps and eoa-1.5, which renders the argument invalid.

@sgfroerer sgfroerer added enhancement New feature or request question Further information is requested labels Jan 18, 2020
@kthoden
Copy link

kthoden commented Jan 21, 2020

Yes, I agree, although not all are necessary.

These could be bundled

  • django-eoapublications (central piece of 1.5)
  • django-eoaauthors
  • django-eoaseries
  • django-opds

This one provides a plugin for the CMS and could be re-used elsewhere

  • django-forthcoming

These are for the umbrella page:

  • django-eoaprojects
  • django-eoackeditor
  • django-eoacmscomponents

Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request question Further information is requested
Development

No branches or pull requests

2 participants