Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Namrata Jha authored and GitHub committed Dec 23, 2021
1 parent 7d188d1 commit 72cc4b2
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 35 deletions.
42 changes: 25 additions & 17 deletions __tests__/delete.test.ts
Original file line number Diff line number Diff line change
@@ -1,26 +1,34 @@
import {Input, InputParams} from '../src/input'
import {deleteVersions, finalIds} from '../src/delete'

jest.setTimeout(10000)
describe('index tests -- call graphql', () => {
it('getVersionIds test -- get oldest version', done => {
it('finalIds test -- get oldest version', done => {
const numVersions = 1

finalIds(getInput({numOldVersionsToDelete: numVersions})).subscribe(ids => {
expect(ids.length).toBeGreaterThanOrEqual(numVersions)
expect(ids.length).toBe(numVersions)
done()
})
})

it('getVersionIds test -- get oldest 3 versions', done => {
it.skip('finalIds test -- get oldest 3 versions', done => {
const numVersions = 3

finalIds(getInput({numOldVersionsToDelete: numVersions})).subscribe(ids => {
expect(ids.length).toBeGreaterThanOrEqual(numVersions)
expect(ids.length).toBe(numVersions)
done()
})
})

it('getVersionIds test -- supplied package version id', done => {
it.skip('finalIds test -- get oldest 110 versions', done => {
const numVersions = 110

finalIds(getInput({numOldVersionsToDelete: numVersions})).subscribe(ids => {
expect(ids.length).toBe(99), async () => done()
})
})

it('finalIds test -- supplied package version id', done => {
const suppliedIds = [
'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA',
'BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB',
Expand Down Expand Up @@ -56,36 +64,36 @@ describe('index tests -- call graphql', () => {
it.skip('deleteVersions test -- delete oldest version', done => {
deleteVersions(getInput({numOldVersionsToDelete: 1})).subscribe(
isSuccess => {
expect(isSuccess).toBe(true)
done()
}
expect(isSuccess)
},
async () => done()
)
})

it.skip('deleteVersions test -- delete 3 oldest versions', done => {
deleteVersions(getInput({numOldVersionsToDelete: 3})).subscribe(
isSuccess => {
expect(isSuccess).toBe(true)
done()
}
expect(isSuccess)
},
async () => done()
)
})

it.skip('deleteVersions test -- keep 5 versions', done => {
deleteVersions(getInput({minVersionsToKeep: 5})).subscribe(isSuccess => {
deleteVersions(getInput({minVersionsToKeep: 100})).subscribe(isSuccess => {
expect(isSuccess).toBe(true)
done()
})
}),
async () => done()
})
})

const defaultInput: InputParams = {
packageVersionIds: [],
owner: 'namratajha',
repo: 'only-pkg',
packageName: 'onlypkg.maven',
packageName: 'only-pkg',
numOldVersionsToDelete: 1,
minVersionsToKeep: 1,
minVersionsToKeep: -1,
ignoreVersions: RegExp('^$'),
token: process.env.GITHUB_TOKEN as string
}
Expand Down
8 changes: 4 additions & 4 deletions __tests__/version/delete-version.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const githubToken = process.env.GITHUB_TOKEN as string
describe.skip('delete tests', () => {
it('deletePackageVersion', async () => {
const response = await deletePackageVersion(
'MDE0OlBhY2thZ2VWZXJzaW9uNjg5OTU1',
'PV_lADOGReZt84AEI7FzgDSHEI',
githubToken
).toPromise()
expect(response).toBe(true)
Expand All @@ -14,9 +14,9 @@ describe.skip('delete tests', () => {
it('deletePackageVersions', async () => {
const response = await deletePackageVersions(
[
'MDE0OlBhY2thZ2VWZXJzaW9uNjk4Mjc0',
'MDE0OlBhY2thZ2VWZXJzaW9uNjk4Mjcx',
'MDE0OlBhY2thZ2VWZXJzaW9uNjk4MjY3'
'PV_lADOGReZt84AEI7FzgDSHDs',
'PV_lADOGReZt84AEI7FzgDSHDY',
'PV_lADOGReZt84AEI7FzgDSHC8'
],
githubToken
).toPromise()
Expand Down
12 changes: 2 additions & 10 deletions __tests__/version/get-version.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@ describe('get versions tests -- call graphql', () => {
})
})

it('getOldestVersions -- succeeds for more than 100 versions', done => {
const numVersions = 110
getOldestVersions({numVersions}).subscribe(result => {
expect(result.versions.length).toBe(100)
done()
})
})

it('getOldestVersions -- fails for invalid repo', done => {
getOldestVersions({repo: 'actions-testin'}).subscribe({
error: err => {
Expand Down Expand Up @@ -56,8 +48,8 @@ interface Params {

const defaultParams = {
owner: 'namratajha',
repo: 'only-pkg',
packageName: 'only-pkg',
repo: 'test-repo',
packageName: 'test-repo',
numVersions: 1,
startCursor: '',
token: process.env.GITHUB_TOKEN as string
Expand Down
1 change: 0 additions & 1 deletion dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ function queryForOldestVersions(owner, repo, packageName, numVersions, startCurs
}
})).pipe(operators_1.catchError((err) => {
const msg = 'query for oldest version failed.';
console.log(`numversions: ${numVersions} startCursor: ${startCursor}`);
return rxjs_1.throwError(err.errors && err.errors.length > 0
? `${msg} ${err.errors[0].message}`
: `${msg} verify input parameters are correct`);
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
"scripts": {
"format": "prettier --write **/*.ts",
"format-check": "prettier --check **/*.ts",
"lint": "eslint src/**/*.ts",
"lint": "eslint src/**/*.ts --fix",
"lint-check": "eslint src/**/*.ts",
"test": "jest",
"build": "npm run format-check && npm run lint && tsc",
"build": "npm run format-check && npm run lint-check && npm run test && tsc",
"pack": "rm -rf ./lib ./dist && npm run build && ncc build"
},
"repository": {
Expand Down
1 change: 0 additions & 1 deletion src/version/get-versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ export function queryForOldestVersions(
).pipe(
catchError((err: GraphQlQueryResponse) => {
const msg = 'query for oldest version failed.'
console.log(`numversions: ${numVersions} startCursor: ${startCursor}`)
return throwError(
err.errors && err.errors.length > 0
? `${msg} ${err.errors[0].message}`
Expand Down

0 comments on commit 72cc4b2

Please sign in to comment.