Skip to content

Commit

Permalink
Don't use ev_window_get_page_title() when creating a bookmark
Browse files Browse the repository at this point in the history
It's confusing because a page can contain multiple destinations, and the
bookmark always jumps to the top of the page.
  • Loading branch information
Carlos Garcia Campos committed Feb 17, 2013
1 parent e11e158 commit 0cf6d56
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions shell/ev-window.c
Original file line number Diff line number Diff line change
Expand Up @@ -4633,12 +4633,10 @@ ev_window_cmd_bookmarks_add (GtkAction *action,
{
EvBookmark bm;
gchar *page_label;
gchar *page_title;

bm.page = ev_document_model_get_page (window->priv->model);
page_label = ev_document_get_page_label (window->priv->document, bm.page);
page_title = ev_window_get_page_title (window, page_label);
bm.title = page_title ? page_title : g_strdup_printf (_("Page %s"), page_label);
bm.title = g_strdup_printf (_("Page %s"), page_label);
g_free (page_label);

/* EvBookmarks takes ownership of bookmark */
Expand Down

0 comments on commit 0cf6d56

Please sign in to comment.