Skip to content

Commit

Permalink
pinctrl: mvebu: remove MPP_REG_CTRL macro
Browse files Browse the repository at this point in the history
Now that each per-SoC pinctrl driver must implement its own get/set
functions, there is no point in keeping the MPP_REG_CTRL macro, whose
purpose was to let the core pinctrl mvebu driver use default get/set
functions. While at it also update the comment about mvebu_mpp_ctrl.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
  • Loading branch information
Thomas Petazzoni authored and Sebastian Hesselbarth committed Feb 25, 2014
1 parent faaa832 commit cffa7a6
Showing 1 changed file with 3 additions and 16 deletions.
19 changes: 3 additions & 16 deletions drivers/pinctrl/mvebu/pinctrl-mvebu.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@
* between two or more different settings, e.g. assign mpp pin 13 to
* uart1 or sata.
*
* If optional mpp_get/_set functions are set these are used to get/set
* a specific mode. Otherwise it is assumed that the mpp control is based
* on 4-bit groups in subsequent registers. The optional mpp_gpio_req/_dir
* functions can be used to allow pin settings with varying gpio pins.
* The mpp_get/_set functions are mandatory and are used to get/set a
* specific mode. The optional mpp_gpio_req/_dir functions can be used
* to allow pin settings with varying gpio pins.
*/
struct mvebu_mpp_ctrl {
const char *name;
Expand Down Expand Up @@ -114,18 +113,6 @@ struct mvebu_pinctrl_soc_info {
int ngpioranges;
};

#define MPP_REG_CTRL(_idl, _idh) \
{ \
.name = NULL, \
.pid = _idl, \
.npins = _idh - _idl + 1, \
.pins = (unsigned[_idh - _idl + 1]) { }, \
.mpp_get = NULL, \
.mpp_set = NULL, \
.mpp_gpio_req = NULL, \
.mpp_gpio_dir = NULL, \
}

#define MPP_FUNC_CTRL(_idl, _idh, _name, _func) \
{ \
.name = _name, \
Expand Down

0 comments on commit cffa7a6

Please sign in to comment.