Skip to content

Commit

Permalink
XCB: Remove an incorrect clipping optimizations
Browse files Browse the repository at this point in the history
It seems like the idea here was to optimize for the special case of a
rectangular clip, where the region operation could be replace by
direction operation on the draw extents. However, we cannot modify the
geometry for all operations, and in particular the glyphs. So remove
this from the common compositing path.

This fixes partial-clip-text in the test suite.

Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Uli Schlachter authored and Chris Wilson committed Oct 14, 2010
1 parent 408033b commit 6fecbb0
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/cairo-xcb-surface-render.c
Original file line number Diff line number Diff line change
Expand Up @@ -2407,9 +2407,6 @@ _clip_and_composite (cairo_xcb_surface_t *dst,
is_empty = ! _cairo_rectangle_intersect (&extents->bounded, &rect);
if (unlikely (is_empty && extents->is_bounded))
return CAIRO_STATUS_SUCCESS;

if (cairo_region_num_rectangles (clip_region) == 1)
clip_region = NULL;
}
}

Expand Down

0 comments on commit 6fecbb0

Please sign in to comment.