Skip to content

Commit

Permalink
xcb: Fix _put_shm_image_boxes if no SHM available
Browse files Browse the repository at this point in the history
This function always returned CAIRO_INT_STATUS_SUCCESS, even if it didn't do
anything. This commit makes the function return CAIRO_INT_STATUS_UNSUPPORTED
instead.

No unit test for this, because we currently do not test the !SHM case
automatically. Perhaps we should?

Signed-off-by: Uli Schlachter <psychon@znc.in>
  • Loading branch information
Uli Schlachter committed Oct 14, 2015
1 parent 0537479 commit d31dc73
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/cairo-xcb-surface.c
Original file line number Diff line number Diff line change
Expand Up @@ -646,9 +646,8 @@ _put_shm_image_boxes (cairo_xcb_surface_t *surface,
shm_info->offset);
}
}
return CAIRO_INT_STATUS_SUCCESS;
}

return CAIRO_INT_STATUS_SUCCESS;
#endif

return CAIRO_INT_STATUS_UNSUPPORTED;
Expand Down

0 comments on commit d31dc73

Please sign in to comment.