Skip to content

Commit

Permalink
Export matches_pack_name() and fix its return value
Browse files Browse the repository at this point in the history
The function sounds boolean; make it behave as one, not "0 for
success, non-zero for failure".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Sep 17, 2007
1 parent d4bb43e commit 000dfd3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ extern void *unpack_entry(struct packed_git *, off_t, enum object_type *, unsign
extern unsigned long unpack_object_header_gently(const unsigned char *buf, unsigned long len, enum object_type *type, unsigned long *sizep);
extern unsigned long get_size_from_delta(struct packed_git *, struct pack_window **, off_t);
extern const char *packed_object_info_detail(struct packed_git *, off_t, unsigned long *, unsigned long *, unsigned int *, unsigned char *);
extern int matches_pack_name(struct packed_git *p, const char *name);

/* Dumb servers support */
extern int update_server_info(int);
Expand Down
14 changes: 7 additions & 7 deletions sha1_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -1684,22 +1684,22 @@ off_t find_pack_entry_one(const unsigned char *sha1,
return 0;
}

static int matches_pack_name(struct packed_git *p, const char *ig)
int matches_pack_name(struct packed_git *p, const char *name)
{
const char *last_c, *c;

if (!strcmp(p->pack_name, ig))
return 0;
if (!strcmp(p->pack_name, name))
return 1;

for (c = p->pack_name, last_c = c; *c;)
if (*c == '/')
last_c = ++c;
else
++c;
if (!strcmp(last_c, ig))
return 0;
if (!strcmp(last_c, name))
return 1;

return 1;
return 0;
}

static int find_pack_entry(const unsigned char *sha1, struct pack_entry *e, const char **ignore_packed)
Expand All @@ -1717,7 +1717,7 @@ static int find_pack_entry(const unsigned char *sha1, struct pack_entry *e, cons
if (ignore_packed) {
const char **ig;
for (ig = ignore_packed; *ig; ig++)
if (!matches_pack_name(p, *ig))
if (matches_pack_name(p, *ig))
break;
if (*ig)
goto next;
Expand Down

0 comments on commit 000dfd3

Please sign in to comment.