Skip to content

Commit

Permalink
t1300: use test_must_fail as appropriate
Browse files Browse the repository at this point in the history
Some of the tests checked the exit code manually, even going
so far as to run git outside of the test_expect harness.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Mar 7, 2009
1 parent c2e9364 commit 003f69b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions t/t1300-repo-config.sh
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,10 @@ test_expect_success 'get bool variable with empty value' \
'git config --bool emptyvalue.variable > output &&
cmp output expect'

git config > output 2>&1

test_expect_success 'no arguments, but no crash' \
"test $? = 129 && grep usage output"
test_expect_success 'no arguments, but no crash' '
test_must_fail git config >output 2>&1 &&
grep usage output
'

cat > .git/config << EOF
[a.b]
Expand Down Expand Up @@ -373,7 +373,7 @@ EOF
test_expect_success 'new variable inserts into proper section' 'cmp .git/config expect'

test_expect_success 'alternative GIT_CONFIG (non-existing file should fail)' \
'git config --file non-existing-config -l; test $? != 0'
'test_must_fail git config --file non-existing-config -l'

cat > other-config << EOF
[ein]
Expand Down

0 comments on commit 003f69b

Please sign in to comment.