Skip to content

Commit

Permalink
difftool: only copy back files modified during directory diff
Browse files Browse the repository at this point in the history
When 'difftool --dir-diff' is used to compare working tree files,
it always copies files from the tmp dir back to the working tree
when the diff tool is closed, even if the files were not modified
by the diff tool.

This causes the file timestamp to change. Files should only be
copied from the tmp dir back to the working copy if they were
actually modified.

Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Tim Henigan authored and Junio C Hamano committed Jul 19, 2012
1 parent 0ce2e39 commit 05df532
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions git-difftool.perl
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use warnings;
use File::Basename qw(dirname);
use File::Copy;
use File::Compare;
use File::Find;
use File::stat;
use File::Path qw(mkpath);
Expand Down Expand Up @@ -336,8 +337,10 @@ sub write_to_file
# files were modified during the diff, then the changes
# should be copied back to the working tree
for my $file (@working_tree) {
copy("$b/$file", "$workdir/$file") or die $!;
chmod(stat("$b/$file")->mode, "$workdir/$file") or die $!;
if (-e "$b/$file" && compare("$b/$file", "$workdir/$file")) {
copy("$b/$file", "$workdir/$file") or die $!;
chmod(stat("$b/$file")->mode, "$workdir/$file") or die $!;
}
}
} else {
if (defined($prompt)) {
Expand Down

0 comments on commit 05df532

Please sign in to comment.