Skip to content

Commit

Permalink
branch, commit, name-rev: ease up boolean conditions
Browse files Browse the repository at this point in the history
Now that the variables are set by OPT_BOOL, which makes sure
to have the values being 0 or 1 after parsing, we do not need
the double negation to map any other value to 1 for integer
variables.

Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Stefan Beller authored and Junio C Hamano committed Aug 7, 2013
1 parent f902207 commit 05efb7b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion builtin/branch.c
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,8 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
if (with_commit || merge_filter != NO_FILTER)
list = 1;

if (!!delete + !!rename + !!force_create + !!list + !!new_upstream + !!unset_upstream > 1)
if (!!delete + !!rename + !!force_create + !!new_upstream +
list + unset_upstream > 1)
usage_with_options(builtin_branch_usage, options);

if (abbrev == -1)
Expand Down
2 changes: 1 addition & 1 deletion builtin/commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@ static int parse_and_validate_options(int argc, const char *argv[],
if (patch_interactive)
interactive = 1;

if (!!also + !!only + !!all + !!interactive > 1)
if (also + only + all + interactive > 1)
die(_("Only one of --include/--only/--all/--interactive/--patch can be used."));
if (argc == 0 && (also || (only && !amend)))
die(_("No paths with --include/--only does not make sense."));
Expand Down
2 changes: 1 addition & 1 deletion builtin/name-rev.c
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)

git_config(git_default_config, NULL);
argc = parse_options(argc, argv, prefix, opts, name_rev_usage, 0);
if (!!all + !!transform_stdin + !!argc > 1) {
if (all + transform_stdin + !!argc > 1) {
error("Specify either a list, or --all, not both!");
usage_with_options(name_rev_usage, opts);
}
Expand Down

0 comments on commit 05efb7b

Please sign in to comment.