Skip to content

Commit

Permalink
Merge branch 'maint-1.6.4' into maint
Browse files Browse the repository at this point in the history
* maint-1.6.4:
  ls-files: excludes should not impact tracked files
  • Loading branch information
Junio C Hamano committed Oct 25, 2009
2 parents 3319df6 + caa7dac commit 071b489
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 8 deletions.
8 changes: 0 additions & 8 deletions builtin-ls-files.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,6 @@ static void show_files(struct dir_struct *dir, const char *prefix)
if (show_cached | show_stage) {
for (i = 0; i < active_nr; i++) {
struct cache_entry *ce = active_cache[i];
int dtype = ce_to_dtype(ce);
if (excluded(dir, ce->name, &dtype) !=
!!(dir->flags & DIR_SHOW_IGNORED))
continue;
if (show_unmerged && !ce_stage(ce))
continue;
if (ce->ce_flags & CE_UPDATE)
Expand All @@ -186,10 +182,6 @@ static void show_files(struct dir_struct *dir, const char *prefix)
struct cache_entry *ce = active_cache[i];
struct stat st;
int err;
int dtype = ce_to_dtype(ce);
if (excluded(dir, ce->name, &dtype) !=
!!(dir->flags & DIR_SHOW_IGNORED))
continue;
if (ce->ce_flags & CE_UPDATE)
continue;
err = lstat(ce->name, &st);
Expand Down
32 changes: 32 additions & 0 deletions t/t3003-ls-files-exclude.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
#!/bin/sh

test_description='ls-files --exclude does not affect index files'
. ./test-lib.sh

test_expect_success 'create repo with file' '
echo content >file &&
git add file &&
git commit -m file &&
echo modification >file
'

check_output() {
test_expect_success "ls-files output contains file ($1)" "
echo '$2' >expect &&
git ls-files --exclude-standard --$1 >output &&
test_cmp expect output
"
}

check_all_output() {
check_output 'cached' 'file'
check_output 'modified' 'file'
}

check_all_output
test_expect_success 'add file to gitignore' '
echo file >.gitignore
'
check_all_output

test_done

0 comments on commit 071b489

Please sign in to comment.