Skip to content

Commit

Permalink
Pass empty file to p4merge where no base is suitable.
Browse files Browse the repository at this point in the history
Modify the p4merge client command to pass a reference to an empty file
instead of the local file when no base revision available.

In the situation where a merge tries to add a file from one branch
into a branch that already contains that file (by name), p4merge
currently seems to have successfully automatically resolved the
'conflict' when it is opened (correctly if the files differed by
just whitespace for example) but leaves the save button disabled. This
means the user of the p4merge client cannot commit the resolved
changes back to disk and merely exits, leaving the original
(merge-conflicted) file intact on the disk.

Provide an empty base file to p4merge so that it leaves the save
button enabled.  This will allow saving of the auto-resolution to
disk.

Signed-off-by: Ciaran Jessup <ciaranj@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ciaran Jessup authored and Junio C Hamano committed May 1, 2011
1 parent ec014ea commit 0a0ec7b
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions git-mergetool--lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -258,12 +258,9 @@ run_merge_tool () {
;;
p4merge)
if merge_mode; then
touch "$BACKUP"
if $base_present; then
"$merge_tool_path" "$BASE" "$LOCAL" "$REMOTE" "$MERGED"
else
"$merge_tool_path" "$LOCAL" "$LOCAL" "$REMOTE" "$MERGED"
fi
touch "$BACKUP"
$base_present || >"$BASE"
"$merge_tool_path" "$BASE" "$LOCAL" "$REMOTE" "$MERGED"
check_unchanged
else
"$merge_tool_path" "$LOCAL" "$REMOTE"
Expand Down

0 comments on commit 0a0ec7b

Please sign in to comment.