Skip to content

Commit

Permalink
tests: change info messages from yellow/brown to cyan
Browse files Browse the repository at this point in the history
Now that we've adopted a "traffic lights" coloring scheme, yellow is
used for warning messages, so we need to re-color info messages to
something less alarmist.  Blue is a universal color for informational
messages; however we are using that for skipped tests in order to
align with the color schemes of other test suites.  Therefore we use
cyan which is also blue-ish, but visually distinct from blue.

This was suggested on the list a while ago and no-one raised any
objections:

    http://thread.gmane.org/gmane.comp.version-control.git/205675/focus=205966

An earlier iteration of this patch used bold cyan, but the point of
this change is to make them less alarming; let's drop the boldness.

Also paint the message to report skipping the whole thing via
GIT_SKIP_TESTS mechanism in the same color as the "info" color
that is used on the final summary line for the entire script.

Signed-off-by: Adam Spiers <git@adamspiers.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Adam Spiers authored and Junio C Hamano committed Dec 20, 2012
1 parent b8fc855 commit 0a6d475
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,9 @@ then
warn)
tput setaf 3;; # brown/yellow
pass)
tput setaf 2;; # green
tput setaf 2;; # green
info)
tput setaf 3;; # brown
tput setaf 6;; # cyan
*)
test -n "$quiet" && return;;
esac
Expand Down Expand Up @@ -584,7 +584,7 @@ for skp in $GIT_SKIP_TESTS
do
case "$this_test" in
$skp)
say_color skip >&3 "skipping test $this_test altogether"
say_color info >&3 "skipping test $this_test altogether"
skip_all="skip all tests in $this_test"
test_done
esac
Expand Down

0 comments on commit 0a6d475

Please sign in to comment.