Skip to content

Commit

Permalink
Merge branch 'jk/remote-curl-squelch-extra-errors'
Browse files Browse the repository at this point in the history
* jk/remote-curl-squelch-extra-errors:
  remote-curl: mark helper-protocol errors more clearly
  remote-curl: use error instead of fprintf(stderr)
  remote-curl: do not complain on EOF from parent git
  • Loading branch information
Junio C Hamano committed Jul 21, 2014
2 parents 19a249b + cdaa4e9 commit 0ac7443
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions remote-curl.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ static curlioerr rpc_ioctl(CURL *handle, int cmd, void *clientp)
rpc->pos = 0;
return CURLIOE_OK;
}
fprintf(stderr, "Unable to rewind rpc post data - try increasing http.postBuffer\n");
error("unable to rewind rpc post data - try increasing http.postBuffer");
return CURLIOE_FAILRESTART;

default:
Expand Down Expand Up @@ -709,7 +709,7 @@ static int fetch_dumb(int nr_heads, struct ref **to_fetch)
free(targets[i]);
free(targets);

return ret ? error("Fetch failed.") : 0;
return ret ? error("fetch failed.") : 0;
}

static int fetch_git(struct discovery *heads,
Expand Down Expand Up @@ -949,7 +949,7 @@ int main(int argc, const char **argv)
git_extract_argv0_path(argv[0]);
setup_git_directory_gently(&nongit);
if (argc < 2) {
fprintf(stderr, "Remote needed\n");
error("remote-curl: usage: git remote-curl <remote> [<url>]");
return 1;
}

Expand All @@ -972,16 +972,14 @@ int main(int argc, const char **argv)

if (strbuf_getline(&buf, stdin, '\n') == EOF) {
if (ferror(stdin))
fprintf(stderr, "Error reading command stream\n");
else
fprintf(stderr, "Unexpected end of command stream\n");
error("remote-curl: error reading command stream from git");
return 1;
}
if (buf.len == 0)
break;
if (starts_with(buf.buf, "fetch ")) {
if (nongit)
die("Fetch attempted without a local repo");
die("remote-curl: fetch attempted without a local repo");
parse_fetch(&buf);

} else if (!strcmp(buf.buf, "list") || starts_with(buf.buf, "list ")) {
Expand Down Expand Up @@ -1017,7 +1015,7 @@ int main(int argc, const char **argv)
printf("\n");
fflush(stdout);
} else {
fprintf(stderr, "Unknown command '%s'\n", buf.buf);
error("remote-curl: unknown command '%s' from git", buf.buf);
return 1;
}
strbuf_reset(&buf);
Expand Down

0 comments on commit 0ac7443

Please sign in to comment.