Skip to content

Commit

Permalink
Support cvs via git-shell
Browse files Browse the repository at this point in the history
This adds cvs support to the git-shell; You can now give new users
a restricted git-shell and they still can commit via git's cvs
emulator.

Note that either the gecos information must be accurate, or you must
provide a $HOME/.gitconfig with the appropriate user credentials.
Since the git-shell is too restricted to allow the user to do it
(on purpose!), it is up to the administrator to take care of that.

Based on an idea by Jan Wielemaker.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Johannes Schindelin authored and Shawn O. Pearce committed Oct 16, 2007
1 parent a2a9150 commit 0c696fe
Showing 1 changed file with 26 additions and 1 deletion.
27 changes: 26 additions & 1 deletion shell.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "cache.h"
#include "quote.h"
#include "exec_cmd.h"
#include "strbuf.h"

static int do_generic_cmd(const char *me, char *arg)
{
Expand All @@ -18,12 +19,34 @@ static int do_generic_cmd(const char *me, char *arg)
return execv_git_cmd(my_argv);
}

static int do_cvs_cmd(const char *me, char *arg)
{
const char *cvsserver_argv[3] = {
"cvsserver", "server", NULL
};
const char *oldpath = getenv("PATH");
struct strbuf newpath = STRBUF_INIT;

if (!arg || strcmp(arg, "server"))
die("git-cvsserver only handles server: %s", arg);

strbuf_addstr(&newpath, git_exec_path());
strbuf_addch(&newpath, ':');
strbuf_addstr(&newpath, oldpath);

setenv("PATH", strbuf_detach(&newpath, NULL), 1);

return execv_git_cmd(cvsserver_argv);
}


static struct commands {
const char *name;
int (*exec)(const char *me, char *arg);
} cmd_list[] = {
{ "git-receive-pack", do_generic_cmd },
{ "git-upload-pack", do_generic_cmd },
{ "cvs", do_cvs_cmd },
{ NULL },
};

Expand All @@ -32,8 +55,10 @@ int main(int argc, char **argv)
char *prog;
struct commands *cmd;

if (argc == 2 && !strcmp(argv[1], "cvs server"))
argv--;
/* We want to see "-c cmd args", and nothing else */
if (argc != 3 || strcmp(argv[1], "-c"))
else if (argc != 3 || strcmp(argv[1], "-c"))
die("What do you think I am? A shell?");

prog = argv[2];
Expand Down

0 comments on commit 0c696fe

Please sign in to comment.