Skip to content

Commit

Permalink
gitk: Wait for the window to become visible after creating it
Browse files Browse the repository at this point in the history
When the git log process returned an error immediately, we were
sometimes getting no main window and no error window displayed,
with the gitk process just hanging waiting for something.  It appears
that the tkwait in show_error, which waits for the error window to
be destroyed, wasn't sufficient to allow the main window or the error
window to be mapped.

This adds a wait in the main startup code after the main window
has been created to wait until it is visible.  This seems to fix the
problem.

Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Paul Mackerras committed Jul 23, 2007
1 parent d23d98d commit 0eafba1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions gitk
Original file line number Diff line number Diff line change
Expand Up @@ -7646,6 +7646,8 @@ set localfrow -1
set lserial 0
setcoords
makewindow
# wait for the window to become visible
tkwait visibility .
wm title . "[file tail $argv0]: [file tail [pwd]]"
readrefs

Expand Down

0 comments on commit 0eafba1

Please sign in to comment.