Skip to content

Commit

Permalink
t3900: test rejecting log message with NULs correctly
Browse files Browse the repository at this point in the history
It is not like that our longer term desire is to someday start
accept log messages with NULs in them, so it is wrong to mark a test
that demonstrates "git commit" that correctly fails given such an
input as "expect-failure".  "git commit" should fail today, and it
should fail the same way in the future given a message with NUL in it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Aug 5, 2013
1 parent 214a5f2 commit 0ed45a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions t/t3900-i18n-commit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ test_expect_success 'no encoding header for base case' '
test z = "z$E"
'

test_expect_failure 'UTF-16 refused because of NULs' '
test_expect_success 'UTF-16 refused because of NULs' '
echo UTF-16 >F &&
git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt
test_must_fail git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt
'


Expand Down

0 comments on commit 0ed45a1

Please sign in to comment.