Skip to content

Commit

Permalink
Bundle file copies from multiple branches into a merge.
Browse files Browse the repository at this point in the history
When copying files and/or directories from several branches in one single
revision, all these branches are used as parents of the commit.

Signed-off-by: Yaacov Akiba Slama <ya@slamail.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Yaacov Akiba Slama authored and Junio C Hamano committed Nov 8, 2005
1 parent 8168373 commit 109fc2b
Showing 1 changed file with 16 additions and 6 deletions.
22 changes: 16 additions & 6 deletions git-svnimport.perl
Original file line number Diff line number Diff line change
Expand Up @@ -365,12 +365,12 @@ ($$)
return $therev;
}

sub copy_path($$$$$$$) {
sub copy_path($$$$$$$$) {
# Somebody copied a whole subdirectory.
# We need to find the index entries from the old version which the
# SVN log entry points to, and add them to the new place.

my($newrev,$newbranch,$path,$oldpath,$rev,$node_kind,$new) = @_;
my($newrev,$newbranch,$path,$oldpath,$rev,$node_kind,$new,$parents) = @_;

my($srcbranch,$srcpath) = split_path($rev,$oldpath);
my $therev = branch_rev($srcbranch, $rev);
Expand All @@ -379,6 +379,9 @@ ($$$$$$$)
print STDERR "$newrev:$newbranch: could not find $oldpath \@ $rev\n";
return;
}
if ($srcbranch ne $newbranch) {
push(@$parents, $branches{$srcbranch}{'LAST'});
}
print "$newrev:$newbranch:$path: copying from $srcbranch:$srcpath @ $rev\n" if $opt_v;
if ($node_kind eq $SVN::Node::dir) {
$srcpath =~ s#/*$#/#;
Expand All @@ -405,7 +408,7 @@ ($$$$$$$)
sub commit {
my($branch, $changed_paths, $revision, $author, $date, $message) = @_;
my($author_name,$author_email,$dest);
my(@old,@new);
my(@old,@new,@parents);

if (not defined $author) {
$author_name = $author_email = "unknown";
Expand Down Expand Up @@ -492,6 +495,8 @@ sub commit {
$last_rev = $rev;
}

push (@parents, $rev) if defined $rev;

my $cid;
if($tag and not %$changed_paths) {
$cid = $rev;
Expand All @@ -507,7 +512,7 @@ sub commit {
if(($action->[0] eq "A") || ($action->[0] eq "R")) {
my $node_kind = node_kind($branch,$path,$revision);
if($action->[1]) {
copy_path($revision,$branch,$path,$action->[1],$action->[2],$node_kind,\@new);
copy_path($revision,$branch,$path,$action->[1],$action->[2],$node_kind,\@new,\@parents);
} elsif ($node_kind eq $SVN::Node::file) {
my $f = get_file($revision,$branch,$path);
if ($f) {
Expand Down Expand Up @@ -592,7 +597,6 @@ sub commit {
$pw->close();

my @par = ();
@par = ("-p",$rev) if defined $rev;

# loose detection of merges
# based on the commit msg
Expand All @@ -602,11 +606,17 @@ sub commit {
if ($mparent eq 'HEAD') { $mparent = $opt_o };
if ( -e "$git_dir/refs/heads/$mparent") {
$mparent = get_headref($mparent, $git_dir);
push @par, '-p', $mparent;
push (@parents, $mparent);
print OUT "Merge parent branch: $mparent\n" if $opt_v;
}
}
}
my %seen_parents = ();
my @unique_parents = grep { ! $seen_parents{$_} ++ } @parents;
foreach my $bparent (@unique_parents) {
push @par, '-p', $bparent;
print OUT "Merge parent branch: $bparent\n" if $opt_v;
}

exec("env",
"GIT_AUTHOR_NAME=$author_name",
Expand Down

0 comments on commit 109fc2b

Please sign in to comment.