Skip to content

Commit

Permalink
Split up default "i18n" and "branch" config parsing into helper routines
Browse files Browse the repository at this point in the history
.. just to finish it off.  We'll leave the pager color config alone,
since it is such an odd-ball special case anyway.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Linus Torvalds authored and Junio C Hamano committed Jun 18, 2008
1 parent d136452 commit 1141f49
Showing 1 changed file with 29 additions and 11 deletions.
40 changes: 29 additions & 11 deletions config.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,25 +488,20 @@ static int git_default_user_config(const char *var, const char *value)
return 0;
}

int git_default_config(const char *var, const char *value, void *dummy)
static int git_default_i18n_config(const char *var, const char *value)
{
if (!prefixcmp(var, "core."))
return git_default_core_config(var, value);

if (!prefixcmp(var, "user."))
return git_default_user_config(var, value);

if (!strcmp(var, "i18n.commitencoding"))
return git_config_string(&git_commit_encoding, var, value);

if (!strcmp(var, "i18n.logoutputencoding"))
return git_config_string(&git_log_output_encoding, var, value);

if (!strcmp(var, "pager.color") || !strcmp(var, "color.pager")) {
pager_use_color = git_config_bool(var,value);
return 0;
}
/* Add other config variables here and to Documentation/config.txt. */
return 0;
}

static int git_default_branch_config(const char *var, const char *value)
{
if (!strcmp(var, "branch.autosetupmerge")) {
if (value && !strcasecmp(value, "always")) {
git_branch_track = BRANCH_TRACK_ALWAYS;
Expand Down Expand Up @@ -535,6 +530,29 @@ int git_default_config(const char *var, const char *value, void *dummy)
return 0;
}

int git_default_config(const char *var, const char *value, void *dummy)
{
if (!prefixcmp(var, "core."))
return git_default_core_config(var, value);

if (!prefixcmp(var, "user."))
return git_default_user_config(var, value);

if (!prefixcmp(var, "i18n."))
return git_default_i18n_config(var, value);

if (!prefixcmp(var, "branch."))
return git_default_branch_config(var, value);

if (!strcmp(var, "pager.color") || !strcmp(var, "color.pager")) {
pager_use_color = git_config_bool(var,value);
return 0;
}

/* Add other config variables here and to Documentation/config.txt. */
return 0;
}

int git_config_from_file(config_fn_t fn, const char *filename, void *data)
{
int ret;
Expand Down

0 comments on commit 1141f49

Please sign in to comment.