Skip to content

Commit

Permalink
test: reword the final message of tests with known breakages
Browse files Browse the repository at this point in the history
When we have known breakages, we still said "passed all N
test(s)", which was a bit funny.

This rewords it to read "passed all remaining N test(s)" in such
a case.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Feb 3, 2008
1 parent 41ac414 commit 11d54b8
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ test_done () {
if test "$test_broken" != 0
then
say_color error "still have $test_broken known breakage(s)"
msg="remaining $(($test_count-$test_broken)) test(s)"
else
msg="$test_count test(s)"
fi
case "$test_failure" in
0)
Expand All @@ -306,11 +309,11 @@ test_done () {
# The Makefile provided will clean this test area so
# we will leave things as they are.

say_color pass "passed all $test_count test(s)"
say_color pass "passed all $msg"
exit 0 ;;

*)
say_color error "failed $test_failure among $test_count test(s)"
say_color error "failed $test_failure among $msg"
exit 1 ;;

esac
Expand Down

0 comments on commit 11d54b8

Please sign in to comment.